Re: [PATCH] net: ethernet: ti: davinci_mdio: Drop commas after match table sentinels

On Fri, 4 Sept 2026 at 06:44, Siddharth Vadapalli [off-list ref] wrote:

On 03/09/26 18:00, Siddharth Vadapalli wrote:

quoted

On 03/09/26 17:36, Geert Uytterhoeven wrote:

quoted

It does not make sense to have a comma after a sentinel, as any new
elements must be added before the sentinel.

While I agree with it, this seems to require a 'cleanup-series' rather than
an individual patch, given the following statistics:

As of [0], running
     git grep "sentinel.*}" drivers/net/ | wc -l
gives
     84
and looking for the ones that terminate in a comma by running
     git grep "sentinel.*}," drivers/net/ | wc -l
gives
     38

So there are '37' other instances (apart from davinci_mdio.c) in
drivers/net alone that require a cleanup.

[...]

quoted

Since this isn't a functional change, I am not sure why a specific change
is required in davinci_mdio.c, unless you plan to cleanup the remaining
'395' occurrences in the remaining code as well. I am not against the
patch, but the reason for picking just davinci_mdio.c for cleanup isn't
clear to me based on the commit message.

I know. Over the past few years, I fixed several of them I encountered,
but never got to fixing all of them. After rc1, I flushed a few patches
that could be sent independently, so there it was!

I have posted the following series to cleanup all networking drivers
(excluding davinci_mdio.c since that is done by your patch) at:
https://lore.kernel.org/r/20260904043724.2955444-1-s-vadapalli@ti.com/ (local)

Happy to see my single patch triggered your great response!
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds