Re: [PATCH net-next 1/4] net: dsa: motorcomm: Split MIB module
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-09-03 15:01:53
Also in:
lkml
On Thu, Sep 03, 2026 at 10:35:06PM +0800, David Yang wrote:
yt922x is going to use a different MIB scheme, split it to reduce the length of chip.c. pp->index = i; - INIT_DELAYED_WORK(&pp->mib_read, yt921x_poll_mib); + INIT_DELAYED_WORK(&pp->mib_read, yt921x_mib_poll);
This suggests the change is not purely moving code around, but also a
rename? I then ask myself, do i need to review the code in detail?
Please try to make patches which move code only move code. Then add
patches which do renames.
Andrew
---
pw-bot: cr