Re: [PATCH net-next v2] net: fec: Propagate PTP initialization errors
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-09-03 14:37:27
Also in:
imx, lkml
On Thu, Sep 03, 2026 at 09:29:11AM +0000, Wei Fang wrote:
quoted
Change fec_ptp_init() to return an error code instead of silently ignoring failures during PTP initialization. The PPS IRQ is not required for the FEC/PTP functionality, so its absence should not make the probe fail. However, an unavailable optional IRQ should be distinguished from an actual error returned during the IRQ lookup. If a platform does not support the PPS IRQ, it can omit the IRQ from its device tree and the optional lookup will return -ENXIO. Propagate other errors from the IRQ lookup instead of silently ignoring them. Also propagate failures from devm_request_irq() and ptp_clock_register(). Update the function declaration in fec.h accordingly. Found by manual code inspection. Fixes: b86bcb299092 ("net: fec_ptp: Use platform_get_irq_xxx_optional() to avoid error message")If this is a bug fix, it should target to net tree rather than net-next.
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html Stable rules say it must be a bug that bothers people. Does this bother you? Andrew