Re: [PATCH net] nexthop: Initialize extack in remove_nh_grp_entry()
From: Eric Dumazet <edumazet@google.com>
Date: 2026-09-03 08:16:09
On Thu, Sep 3, 2026 at 10:03 AM Ido Schimmel [off-list ref] wrote:
remove_nh_grp_entry() prints the extack message when a listener fails
to replace the reduced nexthop group. However, extack is not
initialized and listeners are not required to set a message when
returning an error. Neither netdevsim nor mlxsw do so when an
allocation fails, resulting in the dereference of an uninitialized
stack pointer.
Fix by zero-initializing extack, as was done in commit 6347c5314cee
("nexthop: initialize extack in nh_res_bucket_migrate()").
Fixes: 833a1065eeb1 ("nexthop: Emit a notification when a nexthop group is reduced")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>Reviewed-by: Eric Dumazet <edumazet@google.com>