Re: [PATCH mptcp-next 1/2] selftests: mptcp: convert iptables to nftables for mptcp_sockopt.sh
From: Matthieu Baerts <matttbe@kernel.org>
Date: 2026-09-02 09:17:55
Also in:
bpf, linux-kselftest, lkml, mptcp
Hi Hangbin, On 02/09/2026 08:52, Hangbin Liu wrote:
From: Hangbin Liu <redacted> The per-AF iptables mark rules are replaced with an inet table (msock_table) with separate per-AF counter drop rules for IPv4 and IPv6 drop counting.
Thank you for looking at that!
quoted hunk ↗ jump to hunk
diff --git a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh b/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh index e850a87429b6..4d0af2bf9484 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh
(...)
quoted hunk ↗ jump to hunk
@@ -105,33 +109,23 @@ cleanup() mptcp_lib_check_mptcp mptcp_lib_check_kallsyms -mptcp_lib_check_tools ip "${iptables}" "${ip6tables}" +mptcp_lib_check_tools ip nft check_mark() { local ns=$1 local af=$2 - local tables=${iptables} + drop=$(ip netns exec "$ns" nft list table inet msock_table | \ + grep "ipv$af.*packets.*drop" | awk '{print $(NF-3)}')
Would it not be cleaner to use 'nft -j' and 'jq' to get all the (non-zero) drop counters? Cheers, Matt -- Sponsored by the NGI0 Core fund.