Thread (2 messages) flat view 2 messages, 2 authors, 3d ago

Re: [PATCH net] net: mpls: clear inner_protocol when the last label is popped

From: Jiri Benc <hidden>
Date: 2026-09-02 09:04:01
Also in: stable

On Wed,  2 Sep 2026 16:28:08 +0800, Fourie Zhang wrote:
Fixes: c66549ffd666 ("openvswitch: correctly fragment packet with mpls headers")
The problem was actually introduced by 48d2ab609b6bb ("net: mpls:
Fixups for GSO"), which introduced the skb_set_inner_network_header and
skb_set_inner_protocol in push_mpls but forgot to reset them in
pop_mpls.

Apart of that, the fix looks reasonable to me. This is fortunately a
rather niche bug in practice (and to trigger intentionally, it requires
CAP_NET_ADMIN).

Please resend with the correct Fixes header.

Thanks!

 Jiri
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help