Re: [PATCH net v2] devlink: request flash firmware without instance lock

On Sun, 30 Aug 2026 13:17:00 +0200 Miguel Garcia wrote:

request_firmware() may enter the userspace fallback and call
try_to_freeze(). Holding the devlink instance lock across that call
triggers a lockdep warning and can block unregister for the duration of
the firmware fallback.

Drop the instance lock around firmware loading in both flash update paths.
The callers hold a devlink reference, which also pins the parent device.
Recheck registration after reacquiring the lock before calling into the
driver.

How did you find this issue? Nobody actually uses the user space
fallback, AFAIK? I'd just switch this to request_firmware_direct().
-- 
pw-bot: cr