Re: [PATCH net 1/2] net: macb: exclude software FCS from TX byte statistics

From
Jakub Kicinski <kuba@kernel.org>
Date
2026-08-27 18:56:04
Also in
lkml
Reply to
Nicolai Buchwitz, 2026-08-24
On Mon, 24 Aug 2026 15:47:02 +0200 Nicolai Buchwitz wrote:
+ * @skb_len: skb->len as handed over by the stack, before padding and
+ *           software FCS, only set for the last buffer of the frame
counting pad bytes to ETH_ZLEN as sent is perfectly legit,
it's a driver preference. Some don't because HW pads and
the driver doesn't want to bother adding a conditional.
But it's best if the driver bytes match wire bytes IMO.

Either way, you only need u8 or even a flag for this,
not a full u32?
Thread (12 messages) 12 messages, 5 authors, last reply 2026-08-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help