Re: [PATCH net v2 1/2] netlink: specs: fix the conntrack filter type
From: Asbjørn Sloth Tønnesen <hidden>
Date: 2026-08-27 11:05:21
Also in:
lkml, netfilter-devel, stable
On 8/26/26 10:01 PM, Ilya Maximets wrote:
The CTA_FILTER doesn't contain nested tuple attributes, instead it
contains bit masks that specify which tuple attributes to filter on.
The values for filtering are taken from the top-level CTA_TUPLE_ORIG
and CTA_TUPLE_REPLY, which are also missing in the attribute list
for the dump request.
The bits themselves somehow are not in the public headers, so not
defining them in the spec either for now. Once they are public in
uAPI, they can be added here with enum-as-flags.
Fixes: 23fc9311a526 ("netlink: specs: add conntrack dump and stats dump support")
Cc: stable@vger.kernel.org
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>LGTM, thanks. Reviewed-by: Asbjørn Sloth Tønnesen <redacted>