[PATCH net v2 0/2] tcp: fix use-after-free in do_tcp_getsockopt()
From: Cen Zhang (Microsoft) <hidden>
Date: 2026-08-26 17:14:15
Also in:
bpf, lkml, mptcp
From: "Cen Zhang (Microsoft Security FORGE Labs)" <redacted> do_tcp_getsockopt() has two lockless reads of icsk_ca_ops. Since BPF struct_ops congestion control made icsk_ca_ops point to dynamically allocated memory, a concurrent setsockopt(TCP_CONGESTION) can replace the pointer and free the old object while either reader is using it. Patch 1 fixes the TCP_CONGESTION path by copying ca_ops->name to a stack buffer while holding rcu_read_lock(). It also uses READ_ONCE() for the lockless load and annotates every explicit icsk_ca_ops store with WRITE_ONCE(). Patch 2 fixes the TCP_CC_INFO path by keeping the READ_ONCE() load, ca_ops->get_info lookup, and call inside an RCU read-side critical section. Changes since v1 [1]: - Add READ_ONCE() to both lockless icsk_ca_ops loads. - Add WRITE_ONCE() to all six explicit icsk_ca_ops stores. - Include the data-race annotations in the UAF series as requested by Eric Dumazet [2]. [1] https://lore.kernel.org/all/20260821182449.79785-1-blbllhy@gmail.com/ (local) [2] https://lore.kernel.org/all/CANn89iKr1ypEFeL+7te3xWoNaK5AFyYQmr+pDh2zSZAxfgNKjw@mail.gmail.com/ (local) Cen Zhang (Microsoft Security FORGE Labs) (2): tcp: fix use-after-free in do_tcp_getsockopt(TCP_CONGESTION) tcp: fix use-after-free in do_tcp_getsockopt(TCP_CC_INFO) net/ipv4/tcp.c | 18 ++++++++++++++---- net/ipv4/tcp_cong.c | 4 ++-- net/ipv4/tcp_dctcp.c | 2 +- net/ipv4/tcp_minisocks.c | 2 +- net/ipv4/tcp_output.c | 2 +- net/mptcp/protocol.c | 2 +- 6 files changed, 20 insertions(+), 10 deletions(-) base-commit: f967455fb2a5a2079b9eb5823e9ccf359174bf9f -- 2.55.0