Thread (2 messages) 2 messages, 2 authors, 2026-08-25

Re: [PATCH net] vsock/virtio: flush works in dependency order

flat view

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-08-25 10:41:01
Also in: kvm, lkml, stable, virtualization

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni [off-list ref]:

On Sun, 23 Aug 2026 00:45:56 +0800 you wrote:
virtio_vsock_remove() stops the virtqueues and then flushes each work
item before freeing the enclosing virtio_vsock.  The current order does
not account for dependencies between those items: tx_work may queue
send_pkt_work, and send_pkt_work may queue rx_work.

In particular, send_pkt_work can set restart_rx and release tx_lock.
The remove path can then stop the queues and flush rx_work before
send_pkt_work queues it.  Although the later send_pkt_work flush waits
for that producer to finish, nothing waits for the newly queued rx_work,
so kfree(vsock) can race with it.

[...]
Here is the summary with links:
  - [net] vsock/virtio: flush works in dependency order
    https://git.kernel.org/netdev/net/c/728836ebca23

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help