Re: [PATCH net v2] net/socket: remove unused do_sock_{set,get}sockopt() exports

On Sat, Aug 22, 2026 at 12:39:57PM -0700, Jakub Kicinski wrote:

On Fri, 21 Aug 2026 01:28:32 -0700 Breno Leitao wrote:

quoted

do_sock_setsockopt() and do_sock_getsockopt() have been exported since
they were split out of the syscall handlers for io_uring to reuse.

io_uring is the only caller outside net/socket.c, and it is never
modular: cmd_net.o is built under obj-$(CONFIG_NET), and both CONFIG_NET
and CONFIG_IO_URING are bool. The declarations in <net/sock.h> are all
it needs, so no module has ever been able to use these exports.

FTR I'd prefer this export (or something along these lines) to having 
to add individual helpers for every sockopt for in-kernel networking
socket users. Maybe other maintainers disagree.

Fair — you and Christoph disagree here, and the nvme-tcp series needs it
modular.

I'll park this until that settles. If we decide to keep it, I would
suggest we change it to EXPORT_SYMBOL_GPL, at least.

--
pw-bot: rejected