Thread (4 messages) flat view 4 messages, 2 authors, 27d ago

Re: [PATCH] net: sunplus: fix tx_poll spin_lock missing irqsave in NAPI context

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-08-22 20:51:04
Also in: linux-arm-kernel

On Thu, 20 Aug 2026 15:01:59 +0200 Andrew Gaylard wrote:
spl2sw_tx_poll() runs in NAPI (softirq) context and acquires
comm->tx_lock with plain spin_lock(). The hardirq handler
spl2sw_ethernet_interrupt() acquires the same lock, so a hardirq on
the same CPU while the NAPI poll holds the lock would deadlock with
IRQs disabled. Use spin_lock_irqsave/spin_unlock_irqrestore.
Please explain how the issue was found and how the fix was tested.
I mean - this is an ancient driver, if you don't have a way to test the
fix you should not be sending the patch.
-- 
pw-bot: cr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help