Thread (7 messages) flat view 7 messages, 4 authors, 23d ago

Re: [PATCH net v3 2/2] net: sparx5: fix sleep in atomic context in MAC table access

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-08-20 17:25:00
Also in: linux-arm-kernel, linux-rt-devel, lkml

On Thu, 20 Aug 2026 16:34:43 +0200 Sebastian Andrzej Siewior wrote:
On 2026-08-17 17:41:59 [+0200], Daniel Machon wrote:
…
quoted
Fixes: d6fce5141929 ("net: sparx5: add switching support")
Signed-off-by: Daniel Machon <daniel.machon@microchip.com>  
quoted
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c b/drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c
index 1d34af78166a..4dedf5d92641 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c
@@ -249,7 +254,7 @@ static const struct net_device_ops sparx5_port_netdev_ops = {
 	.ndo_open               = sparx5_port_open,
 	.ndo_stop               = sparx5_port_stop,
 	.ndo_start_xmit         = sparx5_port_xmit_impl,
-	.ndo_set_rx_mode        = sparx5_set_rx_mode,
+	.ndo_set_rx_mode_async  = sparx5_set_rx_mode,
 	.ndo_get_phys_port_name = sparx5_port_get_phys_port_name,
 	.ndo_set_mac_address    = sparx5_set_mac_address,
 	.ndo_validate_addr      = eth_validate_addr,  
d6fce5141929 is v5.14-rc1
ndo_set_rx_mode_async has been introduced in v7.1-rc1.
Youngest LTS kernel is v6.18.

What would be the "fix" for the kernels v5.15 … v6.18?
stable should backport .ndo_set_rx_mode_async
there's been a number of similar fixes, and the whole point of 
the new ndo was to help drivers avoid the sleeping in atomic bugs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help