[PATCH] net: hisilicon: hisi-femac: fix NAPI teardown ordering
From: Jiawen Liu <hidden>
Date: 2026-08-18 13:13:34
Also in:
lkml
Subsystem:
hisilicon network subsystem driver, networking drivers, the rest · Maintainers:
Jian Shen, Jijie Shao, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Remove the redundant explicit NAPI deletion from the registered-device remove path. The confirmed lifecycle contract is that unregister_netdev() performs the NAPI teardown. Probe failure cleanup before registration remains unchanged. Signed-off-by: jiawen <redacted> ---
diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c
--- a/drivers/net/ethernet/hisilicon/hisi_femac.c
+++ b/drivers/net/ethernet/hisilicon/hisi_femac.c@@ -898,7 +898,6 @@ struct net_device *ndev = platform_get_drvdata(pdev); struct hisi_femac_priv *priv = netdev_priv(ndev); - netif_napi_del(&priv->napi); unregister_netdev(ndev); phy_disconnect(ndev->phydev);