Re: [PATCH net] net: do not bond/team netdevices which use ml_priv

From
Hangbin Liu <hidden>
Date
2026-08-18 10:12:34
Reply to
Oliver Hartkopp, 2026-08-15
On Sat, Aug 15, 2026 at 07:23:35PM +0200, Oliver Hartkopp wrote:

On 15.08.26 18:00, Stephen Hemminger wrote:
quoted
On Sat, 15 Aug 2026 17:39:38 +0200
Oliver Hartkopp [off-list ref] wrote:
quoted
+static inline bool netdev_has_ml_priv(struct net_device *dev)
+{
+	return (dev->ml_priv != NULL);
+}
+
Minor suggestion: use const and drop unneeded parens

static inline bool netdev_has_ml_priv(const struct net_device *dev)
{
	return dev->ml_priv != NULL;
}
Good point!

Will wait for some more feedback before sending a v2.
Hi Oliver,

Sashiko gives some feed back[1], would you please check it?

[1] https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260815153938.187073-1-socketcan%40hartkopp.net

Thanks
Hangbin
Thread (15 messages) 15 messages, 4 authors, last reply 28d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help