Thread (15 messages) flat view 15 messages, 2 authors, 7d ago

Re: [PATCH net-next 10/11] bnge: add aRFS flow steering ndo support

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-08-17 23:37:00
Also in: lkml

On Fri, 14 Aug 2026 06:44:34 +0530 Vikas Gupta wrote:
Introduce the ndo_rx_flow_steer callback (bnge_rx_flow_steer) to
support aRFS.
This callback creates an NTUPLE filter that steers matching packets
to the appropriate RX queue. The implementation dissects flow keys
from the SKB, creates an NTUPLE filter with the associated L2 filter,
inserts it into the NTUPLE hash table, and schedules the sp_task
workqueue via BNGE_RX_NTP_FLTR_SP_EVENT to program the filter
in the firmware.
Add bnge_cfg_ntp_filters() called from the periodic timer via sp_task
to handle deferred filter programming and expiration via
rps_may_expire_flow().
This one is not transient:

drivers/net/ethernet/broadcom/bnge/bnge_netdev.c:3168:17: warning: result of comparison of constant 18446744073709551615 with expression of type 'u32' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare]
 3168 |                 if (filter_id == BNGE_FLTR_ID_INVALID)
      |                     ~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help