Re: [PATCH v14 00/12] net: pcs: Introduce support for fwnode PCS

On Thu, 13 Aug 2026 10:35:05 +0200 Christian Marangi wrote:

This series introduce a most awaited feature that is correctly
provide PCS with fwnode without having to use specific export symbol
and additional handling of PCS in phylink.

At times there were 2 different implementation (this and the one
from Sean) but Sean agreed that this can be picked and used in favor
of his implementation as long as his case with race condition is
correctly handled.

Coccicheck says:

  drivers/net/phy/phylink.c:1039:31-34:
    ERROR: invalid reference to the index variable of the iterator on line 1028

  drivers/net/phy/phylink.c:1364:26-29:
    ERROR: invalid reference to the index variable of the iterator on line 1346

  drivers/net/phy/phylink.c:582:7-10:
    ERROR: invalid reference to the index variable of the iterator on line 569

I vaguely recall that you're supposed to make a copy of the pointer,
not just add a "found" boolean. Dunno if it ever happened but Linus
was trying to make the list iterators override the pointer on exit.