Thread (8 messages) flat view 8 messages, 2 authors, 7h ago

Re: [PATCH net-next v1 2/2] net: dsa: realtek: rtl8365mb: add EEE support

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-08-17 14:54:03
Also in: lkml

+static int rtl8365mb_phylink_mac_enable_tx_lpi(struct phylink_config *config,
+					       u32 timer, bool tx_clock_stop)
+{
+	/* The hardware manages LPI itself; there is no MAC-level LPI control.
+	 * This callback only signals LPI awareness to phylink.
+	 */
+	return 0;
+}
+
+static void rtl8365mb_phylink_mac_disable_tx_lpi(struct phylink_config *config)
+{
+}
+
So what happens when i do:

ethtool --set-eee eth42 off

or

ethtool --set-eee eth42 tx-lpi on

I don't now what phylib does with advertise in these cases, but maybe
you need to go behind phylink/phylib back and set advertise to 0, so
that the MAC does the right thing?

Or you need to return -EOPNOTSUPP for these?

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help