Re: [PATCH net v2 3/3] net: stmmac: skip queueMaxSDU check for AF_XDP

From
Simon Horman <horms@kernel.org>
Date
2026-08-17 10:18:00
Also in
bpf, intel-wired-lan, linux-arm-kernel, linux-rdma, lkml
Reply to
Stanislav Fomichev, 2026-08-13
On Thu, Aug 13, 2026 at 12:08:00PM -0700, Stanislav Fomichev wrote:
Commit c5c3e1bfc9e0 ("net: stmmac: Offload queueMaxSDU from tc-taprio")
was inspired by commit 92a0dcb8427d ("igc: offload queue max SDU from
tc-taprio"), but the igc change does not apply the check to AF_XDP.

xsk_tx_peek_desc() reserves a completion entry. Continuing without
queuing or completing the descriptor leaves the AF_XDP rings imbalanced,
so remove the check from the zero-copy path.

The assumptions is that AF_XDP zero-copy traffic bypasses the qdisc, so
taprio's queueMaxSDU check does not apply to this path.

Fixes: c5c3e1bfc9e0 ("net: stmmac: Offload queueMaxSDU from tc-taprio")
Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
Reviewed-by: Simon Horman <horms@kernel.org>
Thread (12 messages) 12 messages, 5 authors, last reply 2026-08-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help