Thread (7 messages) flat view 7 messages, 3 authors, 1d ago

Re: [PATCH v6 2/3] vsock: remove the now-unused rejected flag

From: Stefano Garzarella <sgarzare@redhat.com>
Date: 2026-08-14 09:04:28
Also in: lkml, virtualization

On Fri, Aug 14, 2026 at 01:30:19AM +0800, Nguyen Dinh Phi wrote:
After previous patch, the branch marking a socket rejected in
vsock_accept() is unreachable, and nothing ever sets vsk->rejected
elsewhere.

In fact, since commit d021c344051a ("VSOCK: Introduce VM Sockets"),
where `rejected` was introduced, there has never been a path that sets
sk_err on a listening socket, so that branch has been dead code since
the beginning.

Therefore, we can remove the `rejected` field from vsock_sock structure.

Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Nguyen Dinh Phi <redacted>
---
include/net/af_vsock.h   |  5 +----
net/vmw_vsock/af_vsock.c | 46 +++++++++++++---------------------------
2 files changed, 16 insertions(+), 35 deletions(-)
Thanks for improving the commit description!

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help