Thread (5 messages) flat view 5 messages, 3 authors, 5d ago

Re: [PATCH] net: pcs: rzn1-miic: Fix config array initialization

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2026-08-14 08:11:42
Also in: linux-renesas-soc, lkml

CC Prabhakar

On Thu, 13 Aug 2026 at 20:09, Kyle Hendry via B4 Relay
[off-list ref] wrote:
From: Kyle Hendry <redacted>

Fix memset parameters to initialize the entire DT value array

Signed-off-by: Kyle Hendry <redacted>
Fixes: f39e968dc168a7bd ("net: pcs: rzn1-miic: Move configuration data
to SoC-specific struct")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
quoted hunk ↗ jump to hunk
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -683,7 +683,7 @@ static int miic_parse_dt(struct miic *miic, u32 *mode_cfg)
        if (!dt_val)
                return -ENOMEM;

-       memset(dt_val, MIIC_MODCTRL_CONF_NONE, sizeof(*dt_val));
+       memset(dt_val, MIIC_MODCTRL_CONF_NONE, miic->of_data->conf_conv_count);

        if (of_property_read_u32(np, "renesas,miic-switch-portin", &conf) == 0)
                dt_val[0] = conf;
Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help