Re: [PATCH] net: xilinx: axienet: Propagate errors from optional IRQ lookup

On Wed, Aug 12, 2026 at 01:14:38PM +0700, Bui Duc Phuc wrote:

Hi Andrew,

Thank you for your review.

quoted

quoted

platform_get_irq_optional() returns a positive IRQ number on success or
a negative error code on failure.

........

quoted

quoted

      /* Check for Ethernet core IRQ (optional) */
-     if (lp->eth_irq <= 0)
+     if (lp->eth_irq < 0)
              dev_info(&pdev->dev, "Ethernet core IRQ not defined\n");

What has this change got to do with what is described in the commit
message? If you think this is a needed change, please put it in a
commit of its own, with a good commit message.

lp->eth_irq is assigned from platform_get_irq_optional(), which returns a
positive IRQ number on success or a negative error code on failure.
Therefore, a value of 0 is not possible here, so changing <= 0  to  < 0
is directly related to the error handling described in the commit message.

I think this is a separate change. You can then reference the
documentation, and its example:

https://elixir.bootlin.com/linux/v7.1.8/source/drivers/base/platform.c#L270

	Andrew