Re: [Intel-wired-lan] [PATCH iwl-net] ice: Recalibrate PHY after settime64 on E825-C
From: Paul Menzel <hidden>
Date: 2026-08-12 06:12:15
Also in:
intel-wired-lan
Dear Tony, dear Maciek, Thank you for your patch. Am 12.08.26 um 01:10 schrieb Tony Nguyen:
From: Maciek Machnikowski <redacted> The PHY on E825-C requires recalibration after large jumps of the system time. Add missing PHY recalibration also on E825-C.
Why does it need it? Does the datasheet say so? Hardware errata? How can the issue be reproduced?
quoted hunk ↗ jump to hunk
Fixes: 7cab44f1c35f ("ice: Introduce ETH56G PHY model for E825C products") Signed-off-by: Maciek Machnikowski <redacted> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> --- drivers/net/ethernet/intel/ice/ice_ptp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c index 84b99cfc5675..bf625b9f4991 100644 --- a/drivers/net/ethernet/intel/ice/ice_ptp.c +++ b/drivers/net/ethernet/intel/ice/ice_ptp.c@@ -1956,8 +1956,9 @@ ice_ptp_settime64(struct ptp_clock_info *info, const struct timespec64 *ts) /* Reenable periodic outputs */ ice_ptp_enable_all_perout(pf); - /* Recalibrate and re-enable timestamp blocks for E822/E823 */ - if (hw->mac_type == ICE_MAC_GENERIC) + /* Recalibrate and re-enable timestamp blocks for E822/E823/E825-C */ + if (hw->mac_type == ICE_MAC_GENERIC || + hw->mac_type == ICE_MAC_GENERIC_3K_E825) ice_ptp_restart_all_phy(pf); exit: if (err) {
The diff looks fine: Reviewed-by: Paul Menzel <redacted> Kind regards, Paul