Thread (8 messages) flat view 8 messages, 3 authors, 6d ago

Re: [PATCH bpf-next v4 2/3] bpf, xdp: move offload check into dev_xdp_install()

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-08-12 00:10:49
Also in: bpf, linux-kselftest, lkml

On Tue, 11 Aug 2026 11:06:34 +0800 Jiayuan Chen wrote:
quoted
It may be better to split the series and send this patch to net,
the netdev CI has a netdevsim test for the prog offload, would be
good to run that.  
Though for now bpf_xdp_link_update() already does:

     if (old_prog->type != new_prog->type ||
         old_prog->expected_attach_type != new_prog->expected_attach_type) {
         err = -EINVAL;
         goto out_unlock;
     }

so the other checks can't be triggered on the update path even without 
them in dev_xdp_install().

So I'm thinking this patch works as a standalone fix (good for 
backport), and the cleanup goes as a followup (if necessary)?
Just do it right please. Feels like we are promised a follow up to
every single patch these days :/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help