Thread (32 messages) flat view 32 messages, 4 authors, 11h ago

Re: [PATCH v3 net-next 05/15] neighbour: Remove __rcu from neigh_tables[].

From: David Ahern <dsahern@kernel.org>
Date: 2026-08-11 14:42:01

On 8/10/26 8:23 PM, Kuniyuki Iwashima wrote:
quoted hunk ↗ jump to hunk
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 6fda0052027b..caa52bf64a2d 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -3162,7 +3157,7 @@ int neigh_xmit(int index, struct net_device *dev,
 		struct neighbour *neigh;
 
 		rcu_read_lock();
rcu_read_lock can be moved down after this check.

-		tbl = rcu_dereference(neigh_tables[index]);
+		tbl = neigh_tables[index];
 		if (!tbl) {
 			rcu_read_unlock();
 			goto out_kfree_skb;
Reviewed-by: David Ahern <dsahern@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help