Re: [PATCH net-next v2 2/6] netconsole: use the address family instead of the ipv6 flag

On Mon, Aug 10, 2026 at 05:47:26PM +0100, Gustavo Luiz Duarte wrote:

Now that we have the address family in inet_addr, use that and remove
nt->ipv6.

We no longer need netcons_local_ip_unset() to check that all bytes are
zeroes, as that is now denoted by (family == AF_UNSPEC).

Signed-off-by: Gustavo Luiz Duarte <redacted>

Reviewed-by: Breno Leitao <leitao@debian.org>

- * Test whether the caller left nt->local_ip unset, so that
- * netcons_netpoll_setup() should auto-populate it from the egress device.

This will change the behaviour when a user setting an explict 0.0.0.0 IP
would not have auto-populate (which only happens with family ==
AF_UNSPEC).

At the same time, I don't think this is a big deal, but, I think it is
worth getting this documented.

Please add an additional patch that would make it clear that, if the
user passes an IP (even 0.0.0.0, it will be used, and auto-populate is
only used when no IP is passed)