Re: [PATCH v2 net] l2tp: fix tunnel and session refcount leak on seq_file release
From: Paolo Abeni <pabeni@redhat.com>
Date: 2026-08-11 10:20:52
On 8/10/26 4:11 PM, Eric Dumazet wrote:
quoted hunk ↗ jump to hunk
@@ -1608,8 +1655,8 @@ static __net_init int pppol2tp_init_net(struct net *net) struct proc_dir_entry *pde; int err = 0; - pde = proc_create_net("pppol2tp", 0444, net->proc_net, - &pppol2tp_seq_ops, sizeof(struct pppol2tp_seq_data)); + pde = proc_create_data("pppol2tp", 0444, net->proc_net, + &pppol2tp_proc_ops, net);
It looks like the above does not build with CONFIG_PROC_FS=n:
net/l2tp/l2tp_ppp.c: In function ‘pppol2tp_init_net’:
net/l2tp/l2tp_ppp.c:1659:33: error: ‘pppol2tp_proc_ops’ undeclared (first use in this function); did you mean ‘pppol2tp_chan_ops’?
1659 | &pppol2tp_proc_ops, net);
| ^~~~~~~~~~~~~~~~~
| pppol2tp_chan_ops
/P