On Tue, 4 Aug 2026 23:44:59 -0400 Minxi Hou wrote:
One listener serves the whole test. socat's fork option handles each
association in a child, so the flow rules are the only thing that
changes between the three phases and the listener is never restarted
underneath them.
A forking daemon outlives the pid ovs_netns_spawn_daemon captures,
because the child handling an association is not signalled when only
that pid is killed. Start spawned daemons in their own session so
each leads its own process group, and signal the group on cleanup.
setsid ships in util-linux-core; selftests/vsock/vmtest.sh already
calls it unconditionally in this same tree, so this isn't a new class
of dependency for a kselftest shell script.
Did someone request this? It seems like an overkill just to make sure
socat has exited, no? There's plenty of socat *,fork use in selftests
without setsid. Maybe just set -T/-t to make sure the children exit
in reasonable time?
quoted hunk ↗ jump to hunk
+ # Probe: check if kernel supports sctp flow key.
+ ovs_add_flow "$t" sctp4 \
+ 'in_port(1),eth(),eth_type(0x0800),ipv4(proto=132),sctp(dst=4443)' \
+ '2' &>/dev/null
+ if [ $? -ne 0 ]; then
AI says this is pointless, SCTP support is always built into ovs.
Please drop unless some human explicitly asked for this.
quoted hunk ↗ jump to hunk
+ info "no support for sctp key - skipping"
+ ovs_exit_sig
+ return $ksft_skip
+ fi
--
pw-bot: cr