Re: [PATCH v1] smsc911x: add second read of EEPROM mac when possible corruption seen

Hi Colin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on horms-ipvs/master]
[cannot apply to linus/master v7.2-rc6 next-20260807]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Colin-Foster/smsc911x-add-second-read-of-EEPROM-mac-when-possible-corruption-seen/20260810-123819
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
patch link:    https://lore.kernel.org/r/20250828214452.11683-1-colin.foster%40in-advantage.com
patch subject: [PATCH v1] smsc911x: add second read of EEPROM mac when possible corruption seen
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20260810/202608101549.Sbhie1Im-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260810/202608101549.Sbhie1Im-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot [off-list ref]
| Closes: https://lore.kernel.org/oe-kbuild-all/202608101549.Sbhie1Im-lkp@intel.com/ (local)

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/smsc/smsc911x.c: In function 'smsc911x_read_mac_address':

quoted

drivers/net/ethernet/smsc/smsc911x.c:2179:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]

    2179 |         u8 addr[ETH_ALEN];
         |         ^~


vim +2179 drivers/net/ethernet/smsc/smsc911x.c

631b7568c7d8f0 drivers/net/smsc911x.c               Steve Glendinning 2008-12-25  2160  
31f4574774e98a drivers/net/smsc911x.c               Steve Glendinning 2009-01-27  2161  /* copies the current mac address from hardware to dev->dev_addr */
8489ec1f970064 drivers/net/ethernet/smsc/smsc911x.c Bill Pemberton    2012-12-03  2162  static void smsc911x_read_mac_address(struct net_device *dev)
31f4574774e98a drivers/net/smsc911x.c               Steve Glendinning 2009-01-27  2163  {
31f4574774e98a drivers/net/smsc911x.c               Steve Glendinning 2009-01-27  2164  	struct smsc911x_data *pdata = netdev_priv(dev);
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2165  	u32 mac_high16, mac_low32;
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2166  
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2167  	mac_high16 = smsc911x_mac_read(pdata, ADDRH);
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2168  	mac_low32 = smsc911x_mac_read(pdata, ADDRL);
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2169  
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2170  	/*
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2171  	 * The first mac_read always returns 0. Re-read it to get the
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2172  	 * full MAC
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2173  	 */
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2174  	if (mac_high16 == 0) {
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2175  		SMSC_TRACE(pdata, probe, "Re-read MAC ADDRH\n");
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2176  		mac_high16 = smsc911x_mac_read(pdata, ADDRH);
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2177  	}
8b1e595e2e7800 drivers/net/ethernet/smsc/smsc911x.c Colin Foster      2025-08-28  2178  
f15fef4c0675d4 drivers/net/ethernet/smsc/smsc911x.c Jakub Kicinski    2021-10-18 @2179  	u8 addr[ETH_ALEN];
f15fef4c0675d4 drivers/net/ethernet/smsc/smsc911x.c Jakub Kicinski    2021-10-18  2180  
f15fef4c0675d4 drivers/net/ethernet/smsc/smsc911x.c Jakub Kicinski    2021-10-18  2181  	addr[0] = (u8)(mac_low32);
f15fef4c0675d4 drivers/net/ethernet/smsc/smsc911x.c Jakub Kicinski    2021-10-18  2182  	addr[1] = (u8)(mac_low32 >> 8);
f15fef4c0675d4 drivers/net/ethernet/smsc/smsc911x.c Jakub Kicinski    2021-10-18  2183  	addr[2] = (u8)(mac_low32 >> 16);
f15fef4c0675d4 drivers/net/ethernet/smsc/smsc911x.c Jakub Kicinski    2021-10-18  2184  	addr[3] = (u8)(mac_low32 >> 24);
f15fef4c0675d4 drivers/net/ethernet/smsc/smsc911x.c Jakub Kicinski    2021-10-18  2185  	addr[4] = (u8)(mac_high16);
f15fef4c0675d4 drivers/net/ethernet/smsc/smsc911x.c Jakub Kicinski    2021-10-18  2186  	addr[5] = (u8)(mac_high16 >> 8);
f15fef4c0675d4 drivers/net/ethernet/smsc/smsc911x.c Jakub Kicinski    2021-10-18  2187  	eth_hw_addr_set(dev, addr);
31f4574774e98a drivers/net/smsc911x.c               Steve Glendinning 2009-01-27  2188  }
31f4574774e98a drivers/net/smsc911x.c               Steve Glendinning 2009-01-27  2189  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki