Thread (22 messages) flat view 22 messages, 2 authors, 1d ago

Re: [PATCH net-next v5 00/10] ipv6: report why a route was deleted in RTM_DELROUTE

From: Ido Schimmel <idosch@nvidia.com>
Date: 2026-08-07 15:52:55
Also in: linux-kselftest, lkml

On Fri, Aug 07, 2026 at 07:11:29PM +0900, Yuyang Huang wrote:
Reply to comment in the other sashiko run:

https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260804014714.4362-1-sigefriedhyy%40gmail.com
[...]
quoted
Should the #else branch also get a stub for ip6_del_rt_reason()?
The ip6_del_rt() stub exists only because __remove_nexthop_fib() in
net/ipv4/nexthop.c is obj-y and calls it with CONFIG_IPV6=n. The new
helper has no caller outside net/ipv6/, so a stub for it would be
dead code. I would rather add one when a caller needs it.
But why put it under '#if IS_ENABLED(CONFIG_IPV6)' in the first place?
Just move it above, next to ip6_ins_rt()...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help