Re: [PATCH net] hsr: Avoid holding seqnr_lock while transmitting packets

On Fri, Aug 07, 2026 at 03:16:36PM +0200, Felix Maurer wrote:

Hi Hangbin, hi Simon,

On Fri, Aug 07, 2026 at 08:42:30PM +0800, Hangbin Liu wrote:

quoted

Hi Simon,
On Fri, Aug 07, 2026 at 10:43:25AM +0100, Simon Horman wrote:
[ ... ]

quoted

Simon says:

I don't think the advice on how to annotate this is correct

Tags trump freeform text, but Depends-on is a not a standard tag and as
such should not be used.

I believe that the correct approach would be a tag like this:

  Cc: [off-list ref] # aae9d6b616b5: hsr: Implement more robust duplicate discard for HSR

Link: https://docs.kernel.org/process/stable-kernel-rules.html#option-1

Thanks, I will update with this.

Thank you for the patch! Just to let you know, there is a patch
addressing the same thing in an in-flight patchset [1]. Unfortunately, I
didn't have a lot of time to review in the last weeks, so I'll just
leave this note here so you can coordinate if necessary :)

Thanks,
   Felix


[1]: https://lore.kernel.org/netdev/20260803222211.877-3-xiexinet@gmail.com/ (local)

Oh, interesting. I just came back to work this week and found this issue
when reviewing the syzbot bug list. Since Xie Xin has worked on this,
let's drop my patch and fix it in his patch set.

Cheers
Hangbin