[PATCH net v4 0/4] net: phy: dp83640: fix shared clock lifetime and probe error cleanup
From: <hidden>
Date: 2026-08-07 07:08:39
From: Xuanqiang Luo <redacted>
The DP83640 driver shares one PTP clock between all PHYs on the same MII
bus.
Its driver-local clock lookup and removal scheme can leak the shared clock
on probe failure or free it while another probe is acquiring it.
This series moves the shared clock to the PHY package infrastructure.
Patch 1 adds PHY package locking helpers.
Patch 2 embeds the pin configuration in the shared clock.
Patch 3 clears per-PHY state when PTP clock registration fails.
Patch 4 fixes the shared clock lifetime using the PHY package
infrastructure.
---
Changes:
v4:
Patch 1 (new):
- Add PHY package locking helpers for shared package data.
(Andrew Lunn.)
Patch 2 (new):
- Split the pin configuration storage change into a separate patch and
clarify that the pin functions remain configurable at runtime.
(Andrew Lunn.)
- Clarify the locking comments for pin_config. (Sashiko.)
Patch 3 (new):
- Split the PTP registration failure cleanup into a separate patch.
Patch 4:
- Use the PHY package locking helpers instead of accessing the MII bus
shared lock directly. (Andrew Lunn.)
- Adapt the lifetime fix to the preparatory changes split into separate
patches. (Andrew Lunn.)
v3: https://lore.kernel.org/all/20260805072725.169431-1-xuanqiang.luo@linux.dev/ (local)
- Drop the Suggested-by tag. (Jakub Kicinski.)
- Set err to -ENOMEM on the kzalloc_obj() failure path. (Sashiko.)
- Let devres handle cleanup on driver detach instead of explicitly
releasing the action from .remove(). (Jakub Kicinski.)
v2: https://lore.kernel.org/all/20260730064451.32261-1-xuanqiang.luo@linux.dev/ (local)
- Replace the driver-local clock list and kref with the PHY package API.
(Jakub Kicinski.)
- Use devres to avoid leaking the new package reference on later PHY core
initialization failures.
- Embed the pin configuration in the package private data to simplify
lifetime management.
v1: https://lore.kernel.org/all/20260724023532.14583-1-xuanqiang.luo@linux.dev/ (local)
Xuanqiang Luo (4):
net: phy: add PHY package locking helpers
net: phy: dp83640: embed pin configuration in clock
net: phy: dp83640: clear state after PTP registration failure
net: phy: dp83640: fix per-bus clock lifetime
drivers/net/phy/dp83640.c | 191 +++++++++++++---------------------
drivers/net/phy/phy_package.c | 23 ++++
drivers/net/phy/phylib.h | 2 +
drivers/ptp/Kconfig | 1 +
4 files changed, 98 insertions(+), 119 deletions(-)
--
2.43.0