Re: [PATCH net-next v3 09/15] gve: simplify reset logic

On Wed, Aug 5, 2026 at 6:37 PM Jakub Kicinski [off-list ref] wrote:

On Mon,  3 Aug 2026 18:46:24 +0000 Harshitha Ramamurthy wrote:

quoted

-static void gve_trigger_reset(struct gve_priv *priv);
-
-static void gve_teardown_device_resources(struct gve_priv *priv)
+/**
+ * Request the device to release any allocated shared resources.
+ *
+ * If any part of the teardown step fails, the failure is documented, but is
+ * otherwise ignored. It is expected that a device reset is triggered
+ * immediately after tearing down device resources, which would clear any
+ * lingering state on the device.
+ */
+static void gve_teardown_control_plane_resources(struct gve_priv *priv)
 {

Triggers a warning on W=1 builds:

Warning: drivers/net/ethernet/google/gve/gve_main.c:705 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
 * Request the device to release any allocated shared resources.

Thanks for bringing this up. I will fix this in V4, and address any
actionable review bot feedback.

-- Josh