Re: [PATCH] selftests/net: fin_ack_lat: fix latency threshold typo

From
Brian Grech <hidden>
Date
2026-08-06 15:01:40
Also in
linux-kselftest
Reply to
Simon Horman, 2026-08-06
Hi Simon,

Thank you, yes I can fixup the message and resubmit.


On Thu, Aug 6, 2026 at 8:31 AM Simon Horman [off-list ref] wrote:
On Tue, Aug 04, 2026 at 05:01:08PM -0500, Brian Grech wrote:
quoted
The FIN-ACK latency threshold was written as 100000 (100ms) instead
of the intended 1000000 (1 second). Connections completing between
100ms and 1 second were incorrectly flagged as high-latency outliers
and printed as failures on loaded systems.

Add the missing zero to restore the intended 1 second threshold.

Signed-off-by: Brian Grech <redacted>
---
v2: Added missing maintainer CCs
Hi Brian,

It might be nice to include some information on why 1s is intended.
But I don't think that is strictly necessary.

Also, if this is a fix to be backported (I am unsure) then
it should have a Fixes tag and be targeted at the net branch.

The above notwithstanding, this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

-- 

-Brian
Thread (6 messages) 6 messages, 3 authors, last reply 2026-08-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help