Re: [PATCH bpf-next v3 1/5] net: Add __sys_connect_socket() helper
From: bot+bpf-ci@kernel.org
Date: 2026-08-04 17:50:34
Also in:
bpf
quoted hunk ↗ jump to hunk
diff --git a/net/socket.c b/net/socket.c --- a/net/socket.c +++ b/net/socket.c@@ -2115,27 +2115,31 @@ SYSCALL_DEFINE3(accept, int, fd, struct sockaddr __user *, upeer_sockaddr, * include the -EINPROGRESS status for such sockets. */ +int __sys_connect_socket(struct socket *sock, struct sockaddr_storage *address, + int addrlen, int flags) +{
This isn't a bug, but now that __sys_connect_socket() sits directly under this comment block, would it read better to keep the comment attached to the function that actually copies the address in from user space? The first paragraph mentions "The address is in user space so we verify it is OK and move it to kernel space," but __sys_connect_socket() takes an already-copied struct sockaddr_storage pointer. That user-copy step now lives in __sys_connect() via move_addr_to_kernel().
+ int err;
+
+ err = security_socket_connect(sock, (struct sockaddr *)address, addrlen);
+ if (err)
+ return err;
+
+ return READ_ONCE(sock->ops)->connect(sock,
+ (struct sockaddr_unsized *)address,
+ addrlen, flags);
+}
+
int __sys_connect_file(struct file *file, struct sockaddr_storage *address,
int addrlen, int file_flags)
{
struct socket *sock;
- int err;
sock = sock_from_file(file);
- if (!sock) {
- err = -ENOTSOCK;
- goto out;
- }
+ if (!sock)
+ return -ENOTSOCK;
- err =
- security_socket_connect(sock, (struct sockaddr *)address, addrlen);
- if (err)
- goto out;
-
- err = READ_ONCE(sock->ops)->connect(sock, (struct sockaddr_unsized *)address,
- addrlen, sock->file->f_flags | file_flags);
-out:
- return err;
+ return __sys_connect_socket(sock, address, addrlen,
+ sock->file->f_flags | file_flags);
}[ ... ] --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/30931766736