Thread (7 messages) flat view 7 messages, 4 authors, 10d ago

Re: [PATCH 2/2] qlcnic: move notifier error cleanup under CONFIG_INET

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-08-03 23:22:17
Also in: lkml

On Tue, 28 Jul 2026 11:20:46 +0800 Can Peng wrote:
qlcnic_init_module() registers the netdevice and inetaddr notifiers only
when CONFIG_INET is enabled, but the pci_register_driver() error handling
block is outside that guard.

Move the error check under CONFIG_INET together with the cleanup it
protects. This avoids an empty if statement when CONFIG_INET is disabled
and keeps the cleanup code structured like the guarded registration path.
Waste of time. Like a lot of patches from @kylinos.cn patches, sadly.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help