Re: [PATCH net-next v3 02/13] ax88179_178a: Add HW support for AX179A-based chips
From: Birger Koblitz <hidden>
Date: 2026-07-31 16:06:52
Also in:
linux-usb, lkml
On 24/07/2026 18:22, Andrew Lunn wrote:
quoted
+static void ax88179a_mac_link_up(struct phylink_config *config, + struct phy_device *phy, + unsigned int phy_mode, phy_interface_t interface, + int speed, int duplex, + bool tx_pause, bool rx_pause) +{quoted
+ ax179_data->eee_enabled = ax88179_chk_eee(dev);With phylink, EEE works differently. You need to provide .mac_disable_tx_lpi and .mac_enable_tx_lpi in phylink_mac_ops, and set bp->phylink_config.lpi_capabilities etc. Take a look at
Will be fixed in v4.
commit 0cc425f18f59f992c61c1802331d25ce689ff5d1
Author: Nicolai Buchwitz [off-list ref]
Date: Wed Mar 4 11:54:29 2026 +0100
net: cadence: macb: implement EEE TX LPI support
and there are other examples.Thanks for the pointer!
quoted
+ netif_carrier_on(dev->net);phylink devices never touch the carrier. Leave phylink to set it.
Removed in v4. Birger