Thread (14 messages) flat view 14 messages, 3 authors, 6d ago

Re: [PATCH net-next v6 3/3] selftests/net: devmem.py: add check_rx_large_niov

From: Bobby Eshleman <hidden>
Date: 2026-07-31 00:18:02
Also in: dri-devel, linux-kselftest, linux-media, lkml

On Thu, Jul 30, 2026 at 03:14:33PM -0700, Jakub Kicinski wrote:
On Thu, 30 Jul 2026 14:39:37 -0700 Bobby Eshleman wrote:
quoted
Poking around, it looks like 231.1.167.0 and above should support
everything, so fw should be okay AFAICT.

Looks like the config is missing CONFIG_NET_DEVMEM and CONFIG_UDMABUF?
Ah, damn, you're right. I grepped for DEVMEM and didn't look closely on
a hit. Turns out there's a non-NET DEVMEM, too.
Ha yeah, I kind of did the same at first too, had to grep for
CONFIG.*DEVMEM in net/ to convince myself.
Could you send a patch to add the missing config options to 
tools/testing/selftests/drivers/net/hw/config ?

Can be separate or part of this series, doesn't matter.
SGTM.
quoted
Sorry, took me a while... was certain it was a bug in my code.

Not the failure here, but wondering if this was on ARM led to seeing
that 16K hardcoded rx_page_size in run_rx_large_niov() may fail on ARM
with 64K pages because it will fail the IS_ALIGN(16K, 64K) check...
Ah, good thought. We've been meaning to get an ARM64 server for NIPA
(our current server supplier is out). If it's not too hard could be nice
to guard against that. But also not a huge deal for HW tests if they
fail instead of skipping.
Sounds good, I'll throw in a skip into require_devmem() if rx_page_size
is passed in and doesn't pass the alignment check.

Best,
Bobby
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help