Thread (11 messages) flat view 11 messages, 4 authors, 15d ago

Re: [PATCH net-next v2 5/6] net: phy: mediatek: add calibration logic for AN7581

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-07-30 20:10:42
Also in: linux-arm-kernel, linux-mediatek, lkml

On Fri, 24 Jul 2026 21:08:08 +0200 Christian Marangi wrote:
Airoha AN7581 require dedicated calibration and specific tuneup to make
the Ethernet port work on specific HW PCB layout.

The calibration process is similar to Mediatek PHY but Airoha PHY use
Software calibration process instead of making use of EFUSE.

It does also require some complex table for TX Amp compensation and
multiple register settings for EEE and 10/100M to correctly work.
Also the PHY apply a different TX Amp compensation table based on the
SoC PDIDR version. Such version info is stored in the SCU SoC registers.

Add module version as suggested by Airoha to identify the calibration logic
with a specific version.
Build warning here:

../drivers/net/phy/mediatek/airoha-ge-soc.c:1508:3: warning: variable 'shared' is uninitialized when used here [-Wuninitialized]
 1508 |                 shared->phydev_p0 = phydev;
      |                 ^~~~~~

Sashiko/Gemini has some other review comments so please check before
reposting:
https://sashiko.dev/#/patchset/20260724190811.198339-6-ansuelsmth@gmail.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help