RE: [EXTERNAL] [PATCH net-next v2 1/3] net: prestera: ignore duplicate RIF destruction events
flat view
From: Elad Nachman <enachman@marvell.com>
Date: 2026-07-30 17:50:02
Also in:
linux-wireless, lkml
quoted hunk ↗ jump to hunk
From: Yuyang Huang <redacted> Sent: Saturday, July 11, 2026 3:54 AM To: Yuyang Huang <redacted> Cc: David S. Miller <davem@davemloft.net>; Andrew Lunn <andrew+netdev@lunn.ch>; David Ahern <dsahern@kernel.org>; Elad Nachman <enachman@marvell.com>; Eric Dumazet <redacted>; Ido Schimmel <idosch@nvidia.com>; Jakub Kicinski <kuba@kernel.org>; Johannes Berg <johannes@sipsolutions.net>; Paolo Abeni <pabeni@redhat.com>; Simon Horman <horms@kernel.org>; linux-kernel@vger.kernel.org; linux-wireless@vger.kernel.org; netdev@vger.kernel.org; Kuniyuki Iwashima <kuniyu@google.com> Subject: [EXTERNAL] [PATCH net-next v2 1/3] net: prestera: ignore duplicate RIF destruction events During address teardown, the inetaddr notifier may be called multiple times for the same interface. Ignore NETDEV_DOWN events if the RIF has already been destroyed, rather than returning -EEXIST, which aborts the notifier chain. Cc: Ido Schimmel <mailto:idosch@nvidia.com> Cc: Kuniyuki Iwashima <mailto:kuniyu@google.com> Signed-off-by: Yuyang Huang <mailto:yuyanghuang@google.com> --- drivers/net/ethernet/marvell/prestera/prestera_router.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router.c b/drivers/net/ethernet/marvell/prestera/prestera_router.c index b036b173a308..0c4f462baa6e 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_router.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_router.c@@ -1302,10 +1302,8 @@ static int __prestera_inetaddr_port_event(struct net_device *port_dev, dev_hold(port_dev); break; case NETDEV_DOWN: - if (!re) { - NL_SET_ERR_MSG_MOD(extack, "Can't find RIF"); - return -EEXIST; - } + if (!re) + return 0; prestera_rif_entry_destroy(port->sw, re); dev_put(port_dev); break; --2.55.0.795.g602f6c329a-goog
Acked-by: Elad Nachman <enachman@marvell.com>