Re: [PATCH net] s390/qeth: Check CAP_NET_ADMIN for private ioctls

On 28/07/26 06:36, Jakub Kicinski wrote:

On Thu, 23 Jul 2026 16:00:50 +0200 Aswin Karuvally wrote:

quoted

Gate the SIOCDEVPRIVATE ioctl commands SIOC_QETH_ADP_SET_SNMP_CONTROL,
SIOC_QETH_GET_CARD_TYPE and SIOC_QETH_QUERY_OAT with CAP_NET_ADMIN
capable check to ensure unprivileged users cannot invoke them.

No need to make this netns-aware, I assume?

Hi Jakub,
Thank you for accepting the patch!

It was concluded that the tools that make use of these calls are
strictly meant for IBM OSA cards on an LPAR, which find very limited use
within environments that make use of network namespaces, eg. containers.
Thus stuck with capable().