Re: [PATCH v2 2/3] time/jiffies: Include linux/sysctl.h for proc_int_u2k_conv_uop(), ...
From: Petr Pavlu <petr.pavlu@suse.com>
Date: 2026-07-27 14:58:15
Also in:
bridge, cgroups, dri-devel, driver-core, keyrings, linux-acpi, linux-block, linux-edac, linux-fbdev, linux-fsdevel, linux-modules, linux-nfs, linux-pm, linux-security-module, linuxppc-dev, lkml, ocfs2-devel
On 7/25/26 10:31 PM, Thomas Gleixner wrote:
On Tue, Jul 21 2026 at 15:11, Petr Pavlu wrote:quoted
The kernel/time/jiffies.c file uses proc_int_u2k_conv_uop(),jiffies.c uses ...quoted
proc_int_k2u_conv_kop(), proc_int_conv(), proc_dointvec_conv() and proc_doulongvec_minmax_conv(), which are declared in linux/sysctl.h. It currently relies on this header being included indirectly through linux/module.h -> linux/kmod.h. Add the missing include in preparation for removing the linux/sysctl.h include from linux/kmod.h.Can you please split that spaghetti sentence into paragraphs? https://docs.kernel.org/process/maintainer-tip.html#changelog
I will update it to:
jiffies.c uses proc_int_u2k_conv_uop(), proc_int_k2u_conv_kop(),
proc_int_conv(), proc_dointvec_conv() and proc_doulongvec_minmax_conv(),
which are declared in linux/sysctl.h. It currently gets that header
indirectly through linux/module.h -> linux/kmod.h, but the latter no longer
needs to include linux/sysctl.h.
Include linux/sysctl.h directly in jiffies.c ahead of removing the
unnecessary include from linux/kmod.h.
quoted
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>Other than that. Acked-by: Thomas Gleixner <tglx@kernel.org>
-- Thanks, Petr