Thread (3 messages) read the whole thread 3 messages, 2 authors, 1d ago
WARM1d

[PATCH net-next] ipip: reject unsupported configurations in fill_forward_path

From: Lorenzo Bianconi <lorenzo@kernel.org>
Date: 2026-07-25 09:34:01
Subsystem: networking [general], networking [ipv4/ipv6], the rest · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern, Ido Schimmel, Linus Torvalds

The ipip fill_forward_path callback currently does not check for
configurations that cannot be offloaded to hardware:

- Collect metadata (flow-based) tunnels have no fixed destination
  and rely on per-packet tunnel metadata, so the forward path
  cannot be pre-computed.

- TOS inheritance (parms.iph.tos & 0x1) requires copying the outer
  TOS from the inner packet at encapsulation time, which is not
  known during forward path resolution.

Return -EOPNOTSUPP for both cases to fall back to the software
forwarding path.

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 net/ipv4/ipip.c | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c
index d1aa048a6099..0831f6b81717 100644
--- a/net/ipv4/ipip.c
+++ b/net/ipv4/ipip.c
@@ -360,6 +360,12 @@ static int ipip_fill_forward_path(struct net_device_path_ctx *ctx,
 	const struct iphdr *tiph = &tunnel->parms.iph;
 	struct rtable *rt;
 
+	if (tunnel->collect_md)
+		return -EOPNOTSUPP;
+
+	if (tunnel->parms.iph.tos & 0x1)
+		return -EOPNOTSUPP;
+
 	rt = ip_route_output(dev_net(ctx->dev), tiph->daddr, tiph->saddr,
 			     inet_dsfield_to_dscp(tiph->tos),
 			     tunnel->parms.link, RT_SCOPE_UNIVERSE);
---
base-commit: 04026c998c24ac47eb76886b9790c5710b603eb4
change-id: 20260725-ipip-fill-forward-path-fix-543c41000a57

Best regards,
-- 
Lorenzo Bianconi [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help