Thread (3 messages) 3 messages, 3 authors, 5d ago

Re: [PATCH net-next v2] net/sched: sch_cake: skip clearing unused tins during rate adjustment

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-07-24 23:30:39
Also in: lkml

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Mon, 20 Jul 2026 23:14:52 +0200 you wrote:
When cake_configure_rates() is called from the dequeue path with
rate_adjust=true, it only needs to update the rate parameters. The
loop that clears the unused tins is both unnecessary and harmful in
this path:

 - cake_clear_tin() overwrites q->cur_tin and q->cur_flow, which are
   actively used by cake_dequeue(), corrupting the dequeue state.
 - iterating over the unused tins and their internal queues to purge
   packets adds needless overhead to the hot path.

[...]
Here is the summary with links:
  - [net-next,v2] net/sched: sch_cake: skip clearing unused tins during rate adjustment
    https://git.kernel.org/netdev/net/c/a3729e0df005

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help