Re: [PATCH net-next] net: phylink: add phylink_pcs_loopback() method for PCS loopback support

Besides that, I don't see and PCS that supports that loopback, I think
it would be nice to also have the PCS code for loopback as well...

That is pretty much required for merging. We want to see both sides of
a new API.

There has also been discussion about in which direction should it
loopback. Towards the media or towards the host. For self test you
want host side, but as an exposed feature for user space to enable,
media side could also be interesting. So you should think about what
the internal API looks like to be able to specify the loop direction.

    Andrew