Thread (15 messages) 15 messages, 2 authors, 2d ago

Re: [PATCH net-next v4 11/12] net: mctp: usb: enable v1.1 packet spanning

From: Paolo Abeni <pabeni@redhat.com>
Date: 2026-07-23 11:25:34
Also in: linux-usb

On 7/13/26 4:33 PM, Jeremy Kerr wrote:
quoted hunk ↗ jump to hunk
@@ -333,17 +345,20 @@ static int mctp_usb_probe(struct usb_interface *intf,
 
 	SET_NETDEV_DEV(netdev, &intf->dev);
 	dev = netdev_priv(netdev);
+	dev->span = span;
 	dev->netdev = netdev;
 	dev->usbdev = interface_to_usbdev(intf);
 	dev->intf = intf;
 	spin_lock_init(&dev->rx_lock);
+	if (dev->span)
+		netdev->max_mtu = MCTP_USB_1_1_MTU_MAX;
 	usb_set_intfdata(intf, dev);
 
 	rc = mctp_usblib_rx_init(&dev->rx, le16_to_cpu(ep_in->wMaxPacketSize),
-				 false);
+				 dev->span);
Sashiko has still something to say:

https://sashiko.dev/#/patchset/20260713-dev-mctp-usb-1-1-v4-0-4ae8de764a01%40codeconstruct.com.au

and the race in look real to me.

Note that you are expected to act on AI review feedback autonomously,
either debating it or addressing. A reply on the ML is expected in
either cases.

/P
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help