Thread (5 messages) 5 messages, 5 authors, 4d ago

Re: [PATCH net] vxlan: mdb: Fix source list corruption on a failed replace

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-07-22 21:00:39
Also in: lkml, stable

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Tue, 21 Jul 2026 00:04:24 +0800 you wrote:
When replacing the source list of an MDB remote entry, all existing
sources are first marked for deletion and vxlan_mdb_remote_srcs_add()
is then called to add the new source list. Sources present in the new
list have their deletion mark cleared, and any sources left marked
afterwards are removed.

If vxlan_mdb_remote_srcs_add() fails partway through, its error path
deletes all entries on the remote's source list. That rollback is only
correct for its other caller, vxlan_mdb_remote_add(), where the remote
was just allocated and the list contains solely entries added during
the call. On the replace path the list also holds pre-existing sources,
so a failed replace tears them down together with their (S, G)
forwarding entries instead of leaving the entry unchanged.

[...]
Here is the summary with links:
  - [net] vxlan: mdb: Fix source list corruption on a failed replace
    https://git.kernel.org/netdev/net/c/dcd9b4659654

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help