Re: [PATCH net-next v5 3/8] net: phy: add (*notify_phy_attach/detach)() hooks to struct mii_bus

+	if (phydev->mdio.bus->notify_phy_attach) {
+		err = phydev->mdio.bus->notify_phy_attach(phydev);
+		if (err)
+			goto error;
+		phydev->mdio_bus_notified = true;

It is not normal to keep state like this.

I would expect phy_detach() to only by called if phy_attach_direct
succeeded. So phy_detach() should just call notify_phy_detach.

If something fails in phy_attach_direct() after calling
notify_phy_attach(), the cleanup code should call notify_phy_detach()
to undo what has been done.

   Andrew