Re: [PATCH net-next v9 09/12] net: phylink: add .pcs_link_down PCS OP

Hi,

On 7/17/26 08:54, Christian Marangi wrote:

Permit for PCS driver to define specific operation to tear down the link
between the MAC and the PCS.

This might be needed for some PCS that reset counter or require special
reset to correctly work if the link needs to be restored later.

On phylink_link_down() call, the additional phylink_pcs_link_down() will
be called after .mac_link_down to tear down the link.

PCS driver will need to define .pcs_link_down to make use of this.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

[...]

 
+/**
+ * pcs_link_up() - tear down link between MAC and PCS

      ^^^^^^^^^^^
should be pcs_link_down() :)

With this fixed,

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime